Skip to content

add %kitname% placeholder support to kit load broadcast messages#44

Merged
rossnoah merged 1 commit into
mainfrom
feature/kitname-placeholder
Feb 16, 2026
Merged

add %kitname% placeholder support to kit load broadcast messages#44
rossnoah merged 1 commit into
mainfrom
feature/kitname-placeholder

Conversation

@rossnoah
Copy link
Copy Markdown
Owner

@rossnoah rossnoah commented Feb 16, 2026

Note

Low Risk
Low risk: small, localized change to broadcast message formatting and method signatures for kit-load events only.

Overview
Kit-load broadcast messages now support a new %kitname% placeholder by threading an optional kitName into BroadcastManager.broadcastMessage.

KitManager passes a kit display name when broadcasting private/public kit loads (private uses Kit <slot>, public resolves the configured public kit name with fallback to id), and BroadcastManager updates the public APIs for these broadcasts to accept the kit name and perform the placeholder replacement.

Written by Cursor Bugbot for commit 4e4d5bc. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Kit loading messages now display descriptive kit names instead of generic identifiers, improving clarity for both private and public kits.

@rossnoah rossnoah merged commit 7caa2cb into main Feb 16, 2026
3 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 16, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Kit loading broadcasts now include display names. Private kits use "Kit " format, while public kits use computed display names from the public kit list. Method signatures in BroadcastManager are updated to accept and pass the kit name parameter through the broadcast chain.

Changes

Cohort / File(s) Summary
Kit Loading Broadcasts
src/main/java/dev/noah/perplayerkit/KitManager.java, src/main/java/dev/noah/perplayerkit/util/BroadcastManager.java
Updated kit loading broadcasts to include display names. Private kits use "Kit " format, public kits use computed display names with fallback to kit ID. Method signatures for broadcastPlayerLoadedPrivateKit() and broadcastPlayerLoadedPublicKit() now accept a kitName parameter. New private overload broadcastMessage() added to handle kit name substitution in messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hops with joy at kit displays,
Display names light the loading ways,
Private slots and public pride,
Kit names broadcast far and wide!
Broadcasts bloom with names so bright, 🌟

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/kitname-placeholder

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant